This project is mirrored from https://github.com/prometheus/prometheus.git. Updated .
  1. 07 Oct, 2020 1 commit
  2. 06 Oct, 2020 1 commit
  3. 09 Sep, 2020 1 commit
  4. 27 Aug, 2020 1 commit
  5. 26 Aug, 2020 1 commit
  6. 22 Aug, 2020 1 commit
  7. 11 Aug, 2020 1 commit
  8. 05 Aug, 2020 1 commit
  9. 04 Aug, 2020 1 commit
  10. 02 Aug, 2020 2 commits
  11. 31 Jul, 2020 1 commit
  12. 25 Jul, 2020 2 commits
  13. 24 Jul, 2020 3 commits
  14. 23 Jul, 2020 1 commit
  15. 22 Jul, 2020 1 commit
    • promql: Removed global and add ability to have better interval for subqueries if… · a0df8a38
      promql: Removed global and add ability to have better interval for subqueries if not specified (#7628)
      
      * promql: Removed global and add ability to have better interval for subqueries if not specified
      
      ## Changes
      * Refactored tests for better hints testing
      * Added various TODO in places to enhance.
      * Moved DefaultEvalInterval global to opts with func(rangeMillis int64) int64 function instead
      
      Motivation: At Thanos we would love to have better control over the subqueries step/interval.
      This is important to choose proper resolution. I think having proper step also does not harm for
      Prometheus and remote read users. Especially on stateless querier we do not know evaluation interval
      and in fact putting global can be wrong to assume for Prometheus even.
      
      I think ideally we could try to have at least 3 samples within the range, the same
      way Prometheus UI and Grafana assumes.
      
      Anyway this interfaces allows to decide on promQL user basis.
      
      Open question: Is taking parent interval a smart move?
      
      Motivation for removing global: I spent 1h fighting with:
      
      
      === RUN   TestEvaluations
          TestEvaluations: promql_test.go:31: unexpected error: error evaluating query "absent_over_time(rate(nonexistant[5m])[5m:])" (line 687): unexpected error: runtime error: integer divide by zero
      --- FAIL: TestEvaluations (0.32s)
      FAIL
      
      At the end I found that this fails on most of the versions including this master if you run this test alone. If run together with many
      other tests it passes. This is due to SetDefaultEvaluationInterval(1 * time.Minute)
      in test that is ran before TestEvaluations. Thanks to globals (:
      
      Let's fix it by dropping this global.
      Signed-off-by: 's avatarBartlomiej Plotka <bwplotka@gmail.com>
      
      * Added issue links for TODOs.
      Signed-off-by: 's avatarBartlomiej Plotka <bwplotka@gmail.com>
      
      * Removed irrelevant changes.
      Signed-off-by: 's avatarBartlomiej Plotka <bwplotka@gmail.com>
      Bartlomiej Plotka authored
  16. 17 Jul, 2020 1 commit
  17. 13 Jul, 2020 1 commit
  18. 08 Jul, 2020 1 commit
  19. 30 Jun, 2020 1 commit
  20. 28 Jun, 2020 1 commit
  21. 15 Jun, 2020 1 commit
  22. 09 Jun, 2020 1 commit
  23. 05 Jun, 2020 1 commit
  24. 01 Jun, 2020 1 commit
  25. 31 May, 2020 1 commit
  26. 28 May, 2020 1 commit
  27. 12 May, 2020 1 commit
  28. 29 Apr, 2020 1 commit
  29. 23 Apr, 2020 1 commit
  30. 17 Apr, 2020 1 commit
  31. 15 Apr, 2020 1 commit
  32. 11 Apr, 2020 1 commit
  33. 29 Mar, 2020 1 commit
  34. 23 Mar, 2020 1 commit
  35. 21 Mar, 2020 1 commit
  36. 20 Mar, 2020 1 commit