Unverified Commit 48c4dc63 by Krasi Georgiev Committed by GitHub

github template for PRs (#624)

Signed-off-by: 's avatarKrasi Georgiev <kgeorgie@redhat.com>
parent 4b997005
Don't forget!
- Most PRs would require a CHANGELOG entry.
- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.
- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.
- No tests are needed for internal implementation changes.
- Performance improvements would need a benchmark test to prove it.
- All exposed objects should have a comment.
- All comments should start with a capital letter and end with a full stop.
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment